Skip to content

Allow for multiclass classification #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow for multiclass classification #11

wants to merge 1 commit into from

Conversation

iKintosh
Copy link

Hi,
I noticed that this binding works only with binary classification. I added small change to allow for multiclass classification.
Ideally it should put vec! inside vec!, but it requires changes in a couple of places as well.

@iKintosh iKintosh mentioned this pull request Jun 30, 2024
Open
@jlloh
Copy link
Owner

jlloh commented Jun 30, 2024

Hello, thank you for your contribution!

  1. Would it be possible to add some unit basic tests for multiclass classifications?
  2. We should probably bump the package version in Cargo.toml ?
  3. Perhaps also worth starting a changelog.md file, I can add one and you can rebase from master and add your changes to the changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iKintosh @jlloh